Added ability to send DMs #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaywink
requested changes
Sep 16, 2022
| @@ -88,7 +90,16 @@ async def send_text_to_room( | |||
| logger.exception(f"Unable to send message response to {room_id}") | |||
| return f"Failed to send message: {ex}" | |||
|
|
|||
|
|
|||
| async def get_dm(client: AsyncClient, user: str): | |||
| room_id = self.store.get_dm(user_id=user) | |||
There was a problem hiding this comment.
self wont be defined here, and neither will be store. So you also need to pass in store to this function. Which may be tricky, as the send_text_to_room doesn't know about store either.
Possibly move this logic to Command._message (
middleman/middleman/bot_commands.py
Line 80 in a0e20a2
self.store, and then you can pass in the right room ID to send_text_to_room ? I think logically this is the right way to do it anyway, send_text_to_room is just a helper, _message is the method that processes the "message" command.
|
Additionally, we need to ensure that the room ID is removed from |
Co-authored-by: Jason Robinson <[email protected]>
Co-authored-by: Jason Robinson <[email protected]>
Co-authored-by: Jason Robinson <[email protected]>
Co-authored-by: Jason Robinson <[email protected]>
Co-authored-by: Jason Robinson <[email protected]>
Co-authored-by: Jason Robinson <[email protected]>
Co-authored-by: Jason Robinson <[email protected]>
|
Sorry, I accidentally clicked the button :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to send DMs, if DM room does not exist, create new.