Implemented container
and disablePortal
props
#665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objetive of this PR is to allow a
container
(and an optionaldisablePortal
) prop in order to control where the portal element will be rendered.The implementation was taken from Material UI's Portal component.
This implementation addresses some old issues:
I particularly implemented the feature in order to be able to use reactor in a fullscreen element (similarly to #221 ). If a element is displayed in fullscreen (using the browser's requestFullscreen method reactor won't work as the portal will be rendered in
document.body
. This issue is fixed passingdocument.fullscreenElement
as thecontainer
property to theTour
component. You can check the following example:For anyone needing to use this right now it is published on npm under my user's scope: @nickics/reactour.