Add unit and integration tests for Container activity, covering behavior such as variable scoping, child activity execution, and mixed variable types.
#7102
+520
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avior such as variable scoping, child activity execution, and mixed variable types.
sfmskywalker
requested review from
FransVanEk,
Copilot,
j03y-nxxbz,
lukhipolito and
lukhipolito-nexxbiz
… better code organization
Copilot finished reviewing on behalf of
sfmskywalker
November 24, 2025 17:27
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the Container activity, an abstract base class in Elsa Workflows that controls collections of child activities and variables. The tests verify core functionality including variable scoping, auto-naming of unnamed variables, sequential child activity execution, and proper memory management.
Key Changes:
- Unit tests for
Containeractivity behavior (variable declaration, activity scheduling, auto-naming) - Integration tests for end-to-end workflow execution with containers
- Test workflows demonstrating various container scenarios (nested containers, mixed variable types, dynamic activities)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/unit/Elsa.Activities.UnitTests/Composition/ContainerTests.cs |
Unit tests for Container activity covering variable management, activity scheduling, and edge cases with 250 lines of test code |
test/integration/Elsa.Workflows.IntegrationTests/Activities/Container/ContainerTests.cs |
Integration tests verifying complete workflow execution with containers, including output validation |
test/integration/Elsa.Workflows.IntegrationTests/Activities/Container/Workflows.cs |
Test workflow definitions demonstrating various container scenarios (simple, nested, variables, dynamic) |
test/integration/Elsa.Workflows.IntegrationTests/Activities/Container/TestContainer.cs |
Concrete implementation of abstract Container for testing sequential child activity execution |
test/unit/Elsa.Activities.UnitTests/Composition/ContainerTests.cs
Outdated
Show resolved
Hide resolved
test/integration/Elsa.Workflows.IntegrationTests/Activities/Container/TestContainer.cs
Outdated
Show resolved
Hide resolved
… across test projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is