Skip to content

Add missing indexes for call stack columns in V3_7 migrations #7250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 3 commits into from
Feb 5, 2026
Merged

Add missing indexes for call stack columns in V3_7 migrations #7250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f005213
Initial plan
Copilot Feb 5, 2026
1c5f7ce
Add missing indexes for call stack columns in all provider migrations
Copilot Feb 5, 2026
cd139b1
Optimize migrations by creating columns with correct indexable types
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions src/modules/Elsa.Persistence.EFCore.MySql/Migrations/Runtime/20260122123013_V3_7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,30 +29,63 @@ protected override void Up(MigrationBuilder migrationBuilder)
name: "SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "longtext",
type: "varchar(255)",
nullable: true)
.Annotation("MySql:CharSet", "utf8mb4");

migrationBuilder.AddColumn<string>(
name: "SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "longtext",
type: "varchar(255)",
nullable: true)
.Annotation("MySql:CharSet", "utf8mb4");

migrationBuilder.AddColumn<string>(
name: "SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "longtext",
type: "varchar(255)",
nullable: true)
.Annotation("MySql:CharSet", "utf8mb4");

Copilot AI Feb 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to SQL Server, this modifies an existing V3_7 migration that may have already been deployed. If users have already run the original V3_7 migration, their databases will have these columns with longtext type instead of varchar(255), making them incompatible with indexing.

Consider one of these approaches:

  1. If V3_7 has NOT been released yet, this change is fine.
  2. If V3_7 HAS been released, create a new migration (e.g., V3_7_1 or V3_8) that uses AlterColumn operations to change the column types and then adds the indexes.
  3. Add explicit SQL commands in the Up method to alter the column type if it already exists with the wrong type.
Suggested change
// Ensure the scheduling columns use an indexable type even if they were previously created as LONGTEXT.
var tableName = string.IsNullOrWhiteSpace(_schema.Schema)
? "`ActivityExecutionRecords`"
: $"`{_schema.Schema}`.`ActivityExecutionRecords`";
migrationBuilder.Sql($"""
ALTER TABLE {tableName}
MODIFY COLUMN `SchedulingActivityExecutionId` varchar(255) NULL,
MODIFY COLUMN `SchedulingActivityId` varchar(255) NULL,
MODIFY COLUMN `SchedulingWorkflowInstanceId` varchar(255) NULL;
""");

Copilot uses AI. Check for mistakes.
migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityExecutionId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingWorkflowInstanceId");
}

/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropColumn(
name: "CallStackDepth",
schema: _schema.Schema,
Expand Down
33 changes: 33 additions & 0 deletions src/modules/Elsa.Persistence.EFCore.Oracle/Migrations/Runtime/20260122123056_V3_7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,44 @@ protected override void Up(MigrationBuilder migrationBuilder)
table: "ActivityExecutionRecords",
type: "NVARCHAR2(2000)",
nullable: true);

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityExecutionId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingWorkflowInstanceId");
}

/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropColumn(
name: "CallStackDepth",
schema: _schema.Schema,
Expand Down
33 changes: 33 additions & 0 deletions src/modules/Elsa.Persistence.EFCore.PostgreSql/Migrations/Runtime/20260122123049_V3_7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,44 @@ protected override void Up(MigrationBuilder migrationBuilder)
table: "ActivityExecutionRecords",
type: "text",
nullable: true);

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityExecutionId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingWorkflowInstanceId");
}

/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropColumn(
name: "CallStackDepth",
schema: _schema.Schema,
Expand Down
39 changes: 36 additions & 3 deletions src/modules/Elsa.Persistence.EFCore.SqlServer/Migrations/Runtime/20260122123023_V3_7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,27 +29,60 @@ protected override void Up(MigrationBuilder migrationBuilder)
name: "SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "nvarchar(max)",
type: "nvarchar(450)",
nullable: true);

migrationBuilder.AddColumn<string>(
name: "SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "nvarchar(max)",
type: "nvarchar(450)",
nullable: true);

migrationBuilder.AddColumn<string>(
name: "SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
type: "nvarchar(max)",
type: "nvarchar(450)",
nullable: true);

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityExecutionId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingWorkflowInstanceId");
}

/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropColumn(
name: "CallStackDepth",
schema: _schema.Schema,
Expand Down
33 changes: 33 additions & 0 deletions src/modules/Elsa.Persistence.EFCore.Sqlite/Migrations/Runtime/20260122123040_V3_7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,44 @@ protected override void Up(MigrationBuilder migrationBuilder)
table: "ActivityExecutionRecords",
type: "TEXT",
nullable: true);

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityExecutionId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingActivityId");

migrationBuilder.CreateIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords",
column: "SchedulingWorkflowInstanceId");
}

/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityExecutionId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingActivityId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropIndex(
name: "IX_ActivityExecutionRecord_SchedulingWorkflowInstanceId",
schema: _schema.Schema,
table: "ActivityExecutionRecords");

migrationBuilder.DropColumn(
name: "CallStackDepth",
schema: _schema.Schema,
Expand Down
3 changes: 3 additions & 0 deletions src/modules/Elsa.Persistence.EFCore/Modules/Runtime/Configurations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ public void Configure(EntityTypeBuilder<ActivityExecutionRecord> builder)
builder.HasIndex(x => x.Status).HasDatabaseName($"IX_{nameof(ActivityExecutionRecord)}_{nameof(ActivityExecutionRecord.Status)}");
builder.HasIndex(x => x.CompletedAt).HasDatabaseName($"IX_{nameof(ActivityExecutionRecord)}_{nameof(ActivityExecutionRecord.CompletedAt)}");
builder.HasIndex(x => x.TenantId).HasDatabaseName($"IX_{nameof(ActivityExecutionRecord)}_{nameof(ActivityExecutionRecord.TenantId)}");
builder.HasIndex(x => x.SchedulingActivityExecutionId).HasDatabaseName($"IX_{nameof(ActivityExecutionRecord)}_{nameof(ActivityExecutionRecord.SchedulingActivityExecutionId)}");
builder.HasIndex(x => x.SchedulingActivityId).HasDatabaseName($"IX_{nameof(ActivityExecutionRecord)}_{nameof(ActivityExecutionRecord.SchedulingActivityId)}");
builder.HasIndex(x => x.SchedulingWorkflowInstanceId).HasDatabaseName($"IX_{nameof(ActivityExecutionRecord)}_{nameof(ActivityExecutionRecord.SchedulingWorkflowInstanceId)}");
}

public void Configure(EntityTypeBuilder<BookmarkQueueItem> builder)
Expand Down
Loading