-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add setting to disable live clipboard updates in preview dialog #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a new setting "Disable live clipboard update" that prevents the preview and filename fields from automatically updating when the clipboard changes while the dialog is open. This allows users to safely edit filenames or copy text to use as filenames without the dialog being overwritten by new clipboard content. Changes: - Added disableLiveClipboardUpdate setting (default: false) to Settings.settings - Added property accessor in Settings.Designer.cs - Added menu item to settings context menu in Wizard.Designer.cs - Added handler menuDisableLiveClipboardUpdate_CheckedChanged in Wizard.cs - Modified ClipboardChanged in Dialog.cs to check setting and return early if enabled - Added resource strings str_disable_live_clipboard_update and tooltip The setting is accessible via the settings menu (gear icon) in the Wizard dialog. When enabled, clipboard changes are ignored while the preview/rename dialog is open, preventing the preview and filename fields from being overwritten.
|
Thank you, this sounds like a useful feature! First two general questions:
|
- Checkbox now only appears in main Dialog interface for better discoverability and immediate access - Removed duplicate setting from Wizard settings menu (gear icon) to avoid confusion and keep settings menu clean - Added logic to disable checkbox when batch mode is active, since live updates are required for batch mode to function properly - Setting remains persistent across sessions to respect user preference (defaults to unchecked/enabled) Files modified: - Dialog.cs: Added batch mode check to disable checkbox when appropriate - Wizard.cs: Removed menu item handler - Wizard.Designer.cs: Removed menu item UI component
|
Thanks for reviewing my PR! My original thinking was to hide it in the settings menu just to keep the main interface clean. I mainly built this because I kept trying to copy text to use as a filename, and the dialog would instantly overwrite what I was doing. The batch-mode issue from my last PR is fixed: the option now automatically disables when batch mode is active (batch mode requires live updates). Why move it to the main dialog: Since you mentioned it, I rethought placement users need this toggle while actively using the dialog. So I've updated the PR:
|
|
Hi @chandrath |
- Move readClipboard() calls inside conditional blocks - Only read clipboard in batch mode or when live updates are enabled - Prevents unnecessary clipboard reads when user disables live updates - Fixes issue where readClipboard() was always called regardless of checkbox state
|
Hello, The fix correctly addresses What changed:
Here's the screenshot of the build featuring the new 'Disable Live Clipboard Update' option.
|
- Changed "Disable live clipboard update" to "Live clipboard update" checkbox - Removed all boolean negations for cleaner, direct logic - Eliminated code duplication in ClipboardChanged handler - Added comments clarifying batch mode behavior Addresses all review feedback from @eltos
|
Thank you for the detailed feedback! Initially, I added this feature myself and used it locally for a while. However, the changes I made were not committed; I simply downloaded a local copy and made alterations. Once I was confident the feature was working, I rewrote the code since the original was lost. I then committed the new changes to the PR. Rewriting the feature from scratch after losing my original local implementation led to some initial oversight. I've incorporated your feedback and improved the implementation.
I hope this meets the project's standards. I'm happy to make further adjustments if needed to help improve this excellent tool. |

Added a new setting "Disable live clipboard update" that prevents the preview and filename fields from automatically updating when the clipboard changes while the dialog is open. This allows users to safely edit filenames or copy text to use as filenames without the dialog being overwritten by new clipboard content.
Changes:
The setting is accessible via the settings menu (gear icon) in the Wizard dialog. When enabled, clipboard changes are ignored while the preview/rename dialog is open, preventing the preview and filename fields from being overwritten.
This PR ...
Closes #...
Testing
...
My contribution follows "inbound=outbound" licensing as defined by the GitHub Terms of Service.