Use pnpm package manager instead of yarn #1268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would use pnpm instead of yarn as a package manager.
Relates to #1117:
Conversion to V2 addon is a quite big change that can be hard to debug and review. Since #1117 is already quite old, it would probably be easier to get back to this by splitting the work: first move to pnpm, then work on the monorepo structure to separate the V1 addon package and the test app, then properly convert to V2. I couldn't reuse the commit moving to pnpm since it wasn't isolated from other changes, but maybe #1117 could simply be rebased in the future.
Notes:
volta-cli/action@v4doesn't seem to support pnpm at the moment, unless it's under-documented. It seems that work was done onvolta-clito support pnpm, but the related issue is not closed.