-
Notifications
You must be signed in to change notification settings - Fork 360
Make Jupyterlab pin more flexible to new releases #3320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3320 +/- ##
=======================================
Coverage ? 83.71%
=======================================
Files ? 158
Lines ? 19937
Branches ? 505
=======================================
Hits ? 16691
Misses ? 3057
Partials ? 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think these changes are not enough for that purpose. We'd probably need to downgrade I've tried to install the generated artifact from the CI into JupyterLab ❯ jupyter labextension list
JupyterLab v4.2.7
nbdime-jupyterlab v3.0.2 enabled OK
jupyterlab-plotly v5.22.0 enabled X
@jupyter-server/resource-usage v1.1.1 enabled OK (python, jupyter-resource-usage)
@pyviz/jupyterlab_pyviz v3.0.2 enabled OK
@jupyter-lsp/jupyterlab-lsp v5.1.1 enabled OK (python, jupyterlab-lsp)
@lckr/jupyterlab_variableinspector v3.1.0 enabled OK (python, lckr_jupyterlab_variableinspector)
@elyra/script-debugger-extension v4.0.1-dev enabled X
@elyra/python-editor-extension v4.0.1-dev enabled X
@elyra/scala-editor-extension v4.0.1-dev enabled X
@elyra/ui-components v4.0.1-dev enabled X
@elyra/r-editor-extension v4.0.1-dev enabled X
@elyra/theme-extension v4.0.1-dev enabled X
@elyra/code-snippet-extension v4.0.1-dev enabled X
@elyra/pipeline-editor-extension v4.0.1-dev enabled X
@elyra/services v4.0.1-dev enabled X
@elyra/metadata-extension v4.0.1-dev enabled X
@elyra/metadata-common v4.0.1-dev enabled X
@elyra/script-editor v4.0.1-dev enabled X
@jupyterlab/git v0.51.2 enabled OK (python, jupyterlab-git)
@jupyter-widgets/jupyterlab-manager v3.0.0 enabled X (python, jupyterlab_widgets)
The following extensions may be outdated or specify dependencies that are incompatible with the current version of jupyterlab:
jupyterlab-plotly
@jupyter-widgets/jupyterlab-manager
If you are a user, check if an update is available for these packages.
If you are a developer, re-run with `--verbose` flag for more details.
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/debugger
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/fileeditor
>=7.2.7 <7.3.0 >=7.4.2 <8.0.0 @jupyterlab/services
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/filebrowser
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/fileeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/launcher
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/mainmenu
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/settingregistry
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/filebrowser
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/fileeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/launcher
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/mainmenu
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/settingregistry
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/filebrowser
>=7.2.7 <7.3.0 >=7.4.2 <8.0.0 @jupyterlab/services
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/translation
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/filebrowser
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/fileeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/launcher
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/mainmenu
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/settingregistry
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/launcher
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/mainmenu
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/translation
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codemirror
>=6.2.7 <6.3.0 >=6.4.2 <7.0.0 @jupyterlab/coreutils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/fileeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/markdownviewer
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/notebook
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=6.2.7 <6.3.0 >=6.4.2 <7.0.0 @jupyterlab/coreutils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/filebrowser
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/launcher
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/mainmenu
>=7.2.7 <7.3.0 >=7.4.2 <8.0.0 @jupyterlab/services
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/settingregistry
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=6.2.7 <6.3.0 >=6.4.2 <7.0.0 @jupyterlab/coreutils
>=7.2.7 <7.3.0 >=7.4.2 <8.0.0 @jupyterlab/services
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/translation
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/application
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/translation
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
"@elyra/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab Extension Package
>=4.3.7 <4.4.0 >=4.4.2 <5.0.0 @jupyterlab/apputils
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/codeeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/fileeditor
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/logconsole
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/rendermime
>=7.2.7 <7.3.0 >=7.4.2 <8.0.0 @jupyterlab/services
>=4.2.7 <4.3.0 >=4.4.2 <5.0.0 @jupyterlab/ui-components
Disabled extensions:
@jupyterlab/completer-extension:base-service
@jupyterlab/fileeditor-extension:language-server
@jupyterlab/launcher-extension (all plugins)
@jupyterlab/lsp-extension:settings
@jupyterlab/notebook-extension:language-server |
|
@caponetto let me check. What I was having before was that no matter what i had, I would always go back to 4.2.5, and i wanted to install JupyterLab 4.4.6 and build elyra and maintain that one. Let me check with earlier versions to reproduce your issue. Thanks for checking. |
Signed-off-by: Luciano Resende <[email protected]>
b089b99 to
10201d6
Compare
|
@caponetto I was being to eager on my changes, did a quick update that should solve the problem of downgrading Jupyterlab during build and still make build successful. |
caponetto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that @lresende!
LGTM
Signed-off-by: Luciano Resende <[email protected]>
What changes were proposed in this pull request?
Make Jupyterlab pin more flexible to new releases
How was this pull request tested?
Developer's Certificate of Origin 1.1