Assign path (and other properties) when setting cookie on removal #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have the same issue, even with these new changes. |
Author
|
Hey @sweeetland, Can you share a reproducible repo with the issue you're experiencing? I'm trying to reproduce this issue again on my end but I'm having trouble. Leading me to wonder if this PR is relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was having some trouble removing cookies (they weren't removing). After investigating, it looks like some properties were missing on
Set-Cookiewhen removing a cookie. Adding the additional properties seems to have resolved the issue. Please let me know what you think.Added
defaultOptionsandoptionsin case other properties such asdomainare added.