Skip to content

Conversation

@8549
Copy link

@8549 8549 commented Jan 16, 2026

Closes #94 .

Summary by CodeRabbit

  • New Features
    • Exposed PropsWithChildren type export for public use, allowing users to utilize this type in their applications.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Walkthrough

Added a public type export for PropsWithChildren from @kitajs/html in the main index file. This type is now available to library users without requiring direct imports from the underlying package.

Changes

Cohort / File(s) Summary
Type Export Addition
src/index.ts
Added public type export for PropsWithChildren from @kitajs/html (+1 line)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A type was hiding, tucked away,
The children waiting for their day,
Now Props shine bright from shelf to door,
Exported freely, loved once more! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: export PropsWithChildren' directly and accurately describes the main change: exporting the PropsWithChildren type that was previously unavailable.
Linked Issues check ✅ Passed The pull request directly addresses issue #94 by exporting PropsWithChildren from @kitajs/html, enabling consumers to type components with children as requested.
Out of Scope Changes check ✅ Passed The change is narrowly scoped: only one line added to export PropsWithChildren type, which directly fulfills the requirement stated in issue #94.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0429bc1 and 66f2c44.

📒 Files selected for processing (1)
  • src/index.ts
🔇 Additional comments (1)
src/index.ts (1)

9-10: LGTM — PropsWithChildren is publicly exported in @kitajs/html v4.1.0.

Type-only re-export is clean and matches the issue's intent. The upstream type is available and consumers will be able to import it without errors.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No exported PropsWithChildren type

1 participant