make decorators readonly when accessed through context#176
Draft
ethanniser wants to merge 1 commit intoelysiajs:miyufrom
Draft
make decorators readonly when accessed through context#176ethanniser wants to merge 1 commit intoelysiajs:miyufrom
ethanniser wants to merge 1 commit intoelysiajs:miyufrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is like 2 lines, but seems to have had a ripple effect causing a couple type errors, which I am working to fix
But I would still like your thoughts in the meantime
This pr:
Why?
stateanddecorate, to a user it feels like they are the same thing just one ends up inctxand one inctx.storedecoratorsare immutable (ie a database client, or a config object) and shouldn't be modified, wherestateis mutable and can be modifiedThere is this part from the context page of the docs which I believe shares this sentiment:
Making decorators readonly makes it more clear when a user should use
statevsdecorate, and provides additional safety for large, important global values you want ensure aren't modified