Skip to content

[WIP] GalaxyProject XML #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[WIP] GalaxyProject XML #2333

wants to merge 8 commits into from

Conversation

mtekman
Copy link
Contributor

@mtekman mtekman commented Nov 16, 2020

Add the the GalaxyProject's language server for XML files

https://github.com/galaxyproject/galaxy-language-server

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Nov 16, 2020
yyoncho
yyoncho reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@yyoncho yyoncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you should add the server in docs/lsp-clients.json as well otherwise it won't be displayed in the docs.

mtekman
mtekman commented Nov 17, 2020
View reviewed changes
@mtekman
keywords changed
11f9346
@mtekman
versions changed to 7.1.0
49509eb
@mtekman
alphabetical sort of modules
05553b8
@mtekman
restore previous xml default
a6f046e
@mtekman
changed major mode hook
363c4eb 
 XML files normally load ``nxml-mode'' so this should be the main
 trigger. The ``galaxyxml-mode'' does not yet exist, but could be
 easily implemented to help signal ``lsp-galaxy'' instead of
 ``lsp-xml''
@mtekman
changes
ace7be1 
  the mode was renamed, the major mode was bound to a planemo-mode and
  this was added to the language id variable
@mtekman
Copy link
Contributor Author

mtekman commented Dec 5, 2020

@yyoncho I'm actually unable to get the mode to start, despite registering it correctly (AFAIK).

When I open an xml file, the warning message tells me:

LSP :: There are no language servers supporting current mode `planemo-mode' registered with `lsp-mode'.
This issue might be caused by:
1. The language you are trying to use does not have built-in support in `lsp-mode'. You must install the required support manually. Examples of this are `lsp-java' or `lsp-metals'.
2. The language server that you expect to run is not configured to run for major mode `planemo-mode'. You may check that by checking the `:major-modes' that are passed to `lsp-register-client'.
3. `lsp-mode' doesn't have any integration for the language behind `planemo-mode'. Refer to https://emacs-lsp.github.io/lsp-mode/page/languages and https://langserver.org/ .

@yyoncho
Copy link
Member

yyoncho commented Dec 5, 2020

Can you make sure that the lsp-galaxy.el is loaded?

@mtekman
Copy link
Contributor Author

mtekman commented Dec 5, 2020 •
edited
Loading

I think it is. If I perform an eval-buffer on the "lsp-galaxy.el" buffer, and then in my XML buffer I run (require 'lsp-galaxy) I still get the same message after a file reload

@mtekman mtekman mentioned this pull request Dec 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiennq kiennq kiennq left review comments

@yyoncho yyoncho yyoncho left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtekman @yyoncho @kiennq