[modeline] Add segments to future drop global-mode-string #3188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571
This PR adds 2 new variables:
lsp-modeline-use-global-mode-string
witht
as default which behaves the same as ATM, adding modeling strings to theglobal-mode-string
.lsp-modeline-segments
used in caselsp-modeline-use-global-mode-string
isnil
, indicating the modeling segments features and its order, adding those segments in themode-line-format
before major modes following the sameevil-mode
does.This should standardize the way we add things to modeling and make it easy to improve fixing spacing and other things.
To disable
lsp-modeline-use-global-mode-string
by default, we should at least update major modelines likedoom-emacs modeline
,doom-modeline
, spaceemacs (?) to use thelsp-modeline--string
in their modeling.How it looks on my modeline:
