Rename the option processLines to transformLines#8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames the tangleOrgBabel option processLines to the clearer transformLines, while keeping processLines available as a deprecated alias for backward compatibility.
Changes:
- Added
transformLinesoption totangleOrgBabeland implemented a deprecated fallback toprocessLines(with a warning). - Added tests covering
transformLines, the deprecatedprocessLines, and precedence when both are provided. - Updated README examples/documentation to use
transformLines.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
nix/tangleOrgBabel.nix |
Introduces transformLines and deprecates processLines via an alias with a warning. |
test/test.nix |
Adds coverage for the new option, deprecated option, and precedence behavior. |
README.org |
Updates documentation and examples to use transformLines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/emacs-twist/org-babel/sessions/8a01470e-b4b4-4662-9ecd-23a39c042f9e Co-authored-by: akirak <6270544+akirak@users.noreply.github.com>
Agent-Logs-Url: https://github.com/emacs-twist/org-babel/sessions/1e8c4f96-6417-40bf-9364-c310d5da981c Co-authored-by: akirak <6270544+akirak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name processLines is too vague, and I’ve been meaning to rename it. This time, I will do so while preserving the existing API for backward compatibility.