Functions Recommendations #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emad-elsaid
requested changes
Jun 6, 2020
Comment on lines
11
to
13
| most_liked = user.functions.order(likes_count: :desc).first | ||
| most_commented = user.functions.order(comments_count: :desc).first | ||
| most_saved = user.functions.order(saves_count: :desc).first |
Owner
There was a problem hiding this comment.
It seems we need also to pass the function we need to ignore here, as this is more functions except the current one.
Also it seems that if we ordered by likes_count + comments_count + saves_count that will give us also a good result, which is the most interacted functions first, the most popular functions for this user.
as you know, any one of these 3 lines can return nil which will miss up your line 15 and you'll have to do compact there so a single query on the database with the criteria and order will be better.
akhal3d96
force-pushed
the
functions_recommendations
branch
2 times, most recently
from
5bac43f to
4c78be3
Compare
akhal3d96
force-pushed
the
functions_recommendations
branch
from
4c78be3 to
3edfb9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.