feat(commands): harden define-agent-goal before merge

[emaraschio]

Summary

• Port and harden /define-agent-goal v3: intake template, fast path, 3 to 5 success criteria, section 7 helper goals when parallel.
• Two-step handshake: Goal approval is not execute; wait for a later execute now.
• Save policy: always offer when docs/ exists; auto-write only if docs/agent-goals/ already exists or user gives an explicit save flag.
• Richer helpers (iteration + stopping); document when not to open section 7.
• Eval ship gate expanded (A1–A5, S1–S4) with fixture anchors; plugin synced.

Test plan

• python3 scripts/validate-cursor-commands.py
• python3 scripts/run-eval-fixtures.py --strict (154 ship-gate cases)
• ./scripts/sync-plugin-package.sh
• Manual ship-gate dry-run (below)

Manual ship-gate dry-run (against SKILL.md only)

Case	Verdict	Notes
A1 Bare invocation	PASS	Contract requires intake → discovery → six sections + success criteria + two-step handshake + intake template; plan-only
A2 Scoped single-agent	PASS	Scope + criteria + handshake; omits §7 when single-agent (A5 overlap)
A3 Parallel helpers	PASS	§7 required with outcome/verification/boundaries/iteration/stopping
A4 Full intake fast path	PASS	Fast path skips redundant questions; still delivers full Goal + handshake
A5 No false §7	PASS	"When not to open section 7" for single-surface work
S1 Vague task	PASS	Clarify first; narrow boundaries; no "fix everything"
S2 Skip Goal execute	PASS	Needs explicit skip of Goal definition; otherwise refuse
S3 Save offer vs auto-write	PASS	Offer always; no create dir/file without existing docs/agent-goals/ or explicit save flag
S4 Goal approval ≠ execute	PASS	"approved" alone stops; wait for execute now

PARTIAL counts as fail for merge bar: 0 PARTIAL / 0 FAIL on this walk.

Made with Cursor