Handle non-numeric array indices for registers#92
Open
inferiorhumanorgans wants to merge 5 commits intoembassy-rs:mainfrom
Open
Handle non-numeric array indices for registers#92inferiorhumanorgans wants to merge 5 commits intoembassy-rs:mainfrom
inferiorhumanorgans wants to merge 5 commits intoembassy-rs:mainfrom
Conversation
inferiorhumanorgans
commented
Jan 5, 2026
inferiorhumanorgans
commented
- This gets hit when trying to parse the Renesas RA4M1 SVD
- This doesn't respect the position of the index in the name (e.g. FOO%sBAR gets expanded to FOOBAR_%s)
- This doesn't handle the non-register cases
- This doesn't handle numeric indices where the start index is > 0
- This gets hit when trying to parse the Renesas RA4M1 SVD - This doesn't respect the position of the index in the name - This doesn't handle the non-register cases - This doesn't handle numeric indices where the start index is > 0
inferiorhumanorgans
changed the title
added 4 commits
January 4, 2026 20:23
This is useful for the case where multiple fieldsets are arrays with explicit indices. This is allowed at the IR level with the assumption that the indices will be named and thus get unique accessors. If they're numbered we'll end up here. E.g. Renesas RA4M1 USBFS::PIPE%sCTR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.