mspm0: generate features per chip + package #4194
Merged
+326
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request along with some work on the mspm0-metapac side now allows the
Peripheralstype to only pins that are available for a chip + package combo. This is to match the behavior in embassy-stm32.All the examples and tests build and run as intended.
get_chip_cfgsis a little cursed but that is temporary since I plan to deal with interrupt groups after this.Regarding feature names, I have chosen to exclude temperature rating so the same feature is used before a standard (
S) and Q100 qualfied (Q1) part. Embassy doesn't care whether your parts on tape & reel or tray, so distribution method is excluded.For reference:
Fun fact, there are 128 part numbers for MSPM0 parts. Only 25x less than the STM32. Unfortunately more parts are coming so hopefully TI doesn't catch up soon.