Implement CellWakerRegistration #4196
Open
+87
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkris
force-pushed
the
cell_waker_registration
branch
from
99c1a8c to
111e65e
Compare
`embassy_sync::waitqueue::WakerRegistration` requires mutable reference for doing register/wake operations. In some cases there is no mutable reference to `WakerRegistration` available. This can be worked around by using `RefCell<WakerRegistration>` which has small runtime and memory overhead. I'm implementing an alternative `CellWakerRegistration` which implements interior mutability based on `Cell`. It provides same functionality, but `register/wake` functions accept shared `&CellWakerRegistration` and do not have memory or runtime borrow checking overhead.
tomkris
force-pushed
the
cell_waker_registration
branch
from
111e65e to
4317d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embassy_sync::waitqueue::WakerRegistrationrequires mutable reference for doing register/wake operations.In some cases there is no mutable reference to
WakerRegistrationavailable. This can be worked around by usingRefCell<WakerRegistration>which has small runtime and memory overhead.I'm implementing an alternative
CellWakerRegistrationwhich implements interior mutability based onCell. It provides same functionality, butregister/wakefunctions accept shared&CellWakerRegistrationand do not have memory or runtime borrow checking overhead.