Skip to content

Fix: Get cccd with FIND_INFORMATION instead of READ_BY_TYPE #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonft
Copy link

@simonft simonft commented Apr 10, 2025

Fixes #346

@simonft
Copy link
Author

simonft commented Apr 10, 2025

A couple notes:

I changed get_characteristic_cccd() to no longer return the state of the CCCD from the server because it would require sending an additional message and the value wasn't actually being used anywhere. Happy to change that back though.

I implemented an arm for encode() (copying the format of the ReadByType arm) because it was throwing an error otherwise. I don't understand what that method is for though. Both arms generate bytes from their associated iterators, which parse from bytes. So they end up converting from bytes into messages and then immediately back into those same bytes. If I'm understanding it correctly, attribute_server.rs is where the serialization occurs when response are being sent to clients.

@lulf
Copy link
Member

lulf commented Apr 14, 2025

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get CCCD with ATT_FIND_INFORMATION_REQ instead of ATT_READ_BY_TYPE_REQ
2 participants