Skip to content

add config for the ASMDataTable string pooling #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
embeddedt merged 1 commit into from
May 21, 2026
Merged

add config for the ASMDataTable string pooling #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/org/embeddedt/archaicfix/asm/Mixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public enum Mixin implements IMixins {
"core.MixinStructureStart",
"core.MixinOreDictionary",
"core.MixinChunkProviderHell",
"core.MixinASMData",
"core.MixinNetHandlerPlayServer")
.addClientMixins(
"core.MixinThreadDownloadImageData",
Expand Down Expand Up @@ -171,8 +170,13 @@ public enum Mixin implements IMixins {
.setApplyIf(() -> ArchaicConfig.itemLagReduction)
.addCommonMixins("core.MixinEntityItem")),

MIXINMODCANDIDATE(new ArchaicBuilder()
CANONICALIZE_ASMDATA_TABLE(new ArchaicBuilder()
.setPhase(Phase.EARLY)
.setApplyIf(() -> ArchaicConfig.canonicalizeASMDataTable)
.addCommonMixins("core.MixinASMData")),
CANONICALIZE_ASMDATA_TABLE_NOCOFH(new ArchaicBuilder()
.setPhase(Phase.EARLY)
.setApplyIf(() -> ArchaicConfig.canonicalizeASMDataTable)
.addExcludedMod(TargetedMod.COFHCORE)
.addCommonMixins("core.MixinModCandidate")),

Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/embeddedt/archaicfix/config/ArchaicConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,4 +180,8 @@ public class ArchaicConfig {
@Config.Comment("Disable NEI item rendering in AE2 to fix duplicate stack size rendering when using AE2 rv3-beta-6 with NEI > 2.6.37-GTNH")
@Config.DefaultBoolean(false)
public static boolean disableAE2NEIItemRendering;

@Config.Comment("Reduce RAM usage of the ASMDataTable by pooling some of the Strings")
@Config.DefaultBoolean(true)
public static boolean canonicalizeASMDataTable;
}
Loading