Skip to content

Determine Property Types in Native Classes #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dill-larson
Copy link

PR Category

  • New feature (code which adds functionality)

Requirement/Problem

Add ability to distinguish property/method types in Native JS classes, for later consumption of reportUnorderedProperties
Relates to #417

Solution

  • Create separate helper to separate logic for Ember Classic Objects vs. Ember Octane (Glimmer) Native Classes
    • Create separate naming conventions for new properties since getters/setters ≠ 'single-line-functions'
    • For consumption of order-in-* rule, users should specify them to be treated equally
      e.g. ['single-line-function', 'single-line-accessor']
      e.g. ['actions', 'action']

ToDo

  • In separate PR
    • Consume new helper in reportUnorderedProperties and wire-up to order-in-* rules
    • Update docs and default values for order-in-* rules

@NullVoxPopuli
Copy link
Contributor

looks like some tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants