Skip to content

Add Store extends EmberObject ember data deprecation #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Add Store extends EmberObject ember data deprecation #1400

merged 1 commit into from
Apr 4, 2025

Conversation

kategengler
Copy link
Contributor

No description provided.

@kategengler kategengler requested a review from runspired April 4, 2025 18:44
@netlify Netlify
Copy link

netlify bot commented Apr 4, 2025 •
edited
Loading

✅ Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit c255892
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/67f028a2386ebf000854b0f9
😎 Deploy Preview https://deploy-preview-1400--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kategengler kategengler mentioned this pull request Apr 4, 2025
Merged
@kategengler
Copy link
Contributor Author

I'm merging over Percy since it doesn't seem to be running.

@kategengler kategengler merged commit 95e4ab7 into ember-learn:main Apr 4, 2025
3 checks passed
@kategengler kategengler deleted the kg-add-ember-data-store-extends-deprecation branch April 4, 2025 22:22
@mansona
Copy link
Member

mansona commented Apr 7, 2025

just FYI the "type" for since and until was wrong in this 🙈 I have fixed the issue and made a test that prevents this from happening again: #1401

@kategengler
Copy link
Contributor Author

@mansona I think they are wrong then for a bunch of the ember-source deps (I copied one of them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

@runspired runspired Awaiting requested review from runspired

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kategengler @mansona @NullVoxPopuli