Skip to content

Add RFCs to ember-data 5.x deprecations (for which I could find the RFCs) #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Add RFCs to ember-data 5.x deprecations (for which I could find the RFCs) #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions content/ember-data/v5/ember-data-deprecate-legacy-imports.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@ title: Legacy Imports
until: '6.0'
since: '5.3'
displayId: ember-data:deprecate-legacy-imports
rfc: https://rfcs.emberjs.com/id/0743-ember-data-deprecate-legacy-imports
---

Deprecates importing from `ember-data/*` instead of `@ember-data/*` in order to prepare for the eventual removal of the legacy `ember-data/*`

All imports from `ember-data/*` should be updated to `@ember-data/*` except for `ember-data/store`. When you are using `ember-data` (as opposed to installing the individual packages) you should import from `ember-data/store` instead of `@ember-data/store` in order to receive the appropriate configuration of defaults.

<!-- TODO: gather list of imports that need to be updated -->

This deprecation was introduced in RFC [#0743](https://rfcs.emberjs.com/id/0743-ember-data-deprecate-legacy-imports).
3 changes: 3 additions & 0 deletions content/ember-data/v5/ember-data-deprecate-non-strict-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ title: Non Strict Types
until: '6.0'
since: '5.3'
displayId: ember-data:deprecate-non-strict-types
rfc: https://rfcs.emberjs.com/id/0740-ember-data-deprecate-non-strict-types
---

Currently, EmberData expects that the `type` property associated with a resource follows several conventions.
Expand All @@ -20,3 +21,5 @@ E.G. It will matter not that your string is in a specific format like singular,
If using @ember-data/model, there will always be a restriction that the `type` must match the path on disk where the model is defined.

e.g. `app/models/foo/bar-bem.js` must have a type of `foo/bar-bem`

This deprecation was introduced in RFC [#0740](https://rfcs.emberjs.com/id/0740-ember-data-deprecate-non-strict-types).
3 changes: 2 additions & 1 deletion content/ember-data/v5/ember-data-deprecate-store-extends-ember-object.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ title: Store will no longer extend EmberObject in 6.0
until: '6.0'
since: '5.4'
displayId: ember-data:deprecate-store-extends-ember-object
rfc: https://rfcs.emberjs.com/id/1026-ember-data-deprecate-store-extends-ember-object
---

The Store class extending from EmberObject is deprecated and the class will no
Expand All @@ -28,4 +29,4 @@ If you are unsure whether your Store class uses EmberObject APIs, set this
config and uses of those APIs will throw exceptions. The most common API that
may have been used is `Store.extend({...`.

This deprecation is from RFC [#1026](https://rfcs.emberjs.com/id/1026-ember-data-deprecate-store-extends-ember-object).
This deprecation was introduced in RFC [#1026](https://rfcs.emberjs.com/id/1026-ember-data-deprecate-store-extends-ember-object).