Fix: Lint across the app #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-help-wanted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mansona
requested changes
Mar 13, 2025
app/templates/index.hbs
Outdated
| alt="" | ||
| role="presentation" | ||
| src="../images/ember-help-wanted-logo.svg" | ||
| alt="help wanted" src="../images/ember-help-wanted-logo.svg" |
There was a problem hiding this comment.
This should stay as role presentation, I think the rule was no-redundant-role because we had an empty alt and a role=presentation but we only need one of those two things
There was a problem hiding this comment.
breaks if we add role="presentation"
There was a problem hiding this comment.
@MehulKChaudhari @mansona FWIW this is what co-pilot was suggesting (there is still a linting error).
There was a problem hiding this comment.
Lets keep it alt=""?
mansona
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix lint across the app