Improve Ember users #1159
Improve Ember users #1159
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MinThaMie
left a comment
MinThaMie
left a comment
There was a problem hiding this comment.
Thanks for this work :) I was wondering, since you made some of the bigger companies featured, do you/we know if they are still using Ember? Otherwise I might want to feature some smaller but active companies like Phorest
|
Yeah, that was my line of thinking too. But no idea how we figure that out, seems like a much longer process. Or is it "As far as we last knew..." and wait for someone from X/Y company to issue a correction? Better to ask forgiveness than permission? I don't know the right answer TBH. One thing we could do is stratify it so we can push smaller and active companies higher and keep the blue chippy/unicorny businesses at the top? |
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
Hey thanks for the contribution 🎉 I can explain why your attempt to use store.query() didn't work, essentially the Ember Website is built using "JamStack" techniques and the backend isn't a real backend, it's a set of static JSON files that are generated at build time. Because they are automatically generated there is no way to pass a "query" to the static json and you really just have to do what you did in this PR, get everything and filter the result on the client side.
As for this PR, I think we need to simplify it a bit. Any user that has a url that is pointing at a dead website should be removed and not "filtered" based on their active status. We have a history of previous companies in git if we just delete the files and tbh it's much easier to manage.
As for the idea of featured, let's not add that in for now. There is a much wider discussion to be had about adding a feature like that and I would prefer to get your hard work on filtering out the dead links merged and not blocking on that 👍
Does that all make sense?
|
Hey @mansona, First point - I had assumed as much, I was just unsure is there was some other magic going on. Either way, I'll revert it for now given the rest of your request Filtering vs deletion - I had originally intended to just delete them as you've suggested, but I discovered the inactive thing already existed, but seemed out of use, plus some ambiguity about the pre-existing inactive users and how much crossover there is with the list I compiled. When looking into the data, about 40% of the companies on my list were already marked as inactive. Just to confirm - if it's on the list, do we just delete it and ignore the inactive flag for now? The featured flag already exists and is in use, the ones I've added aren't that contentious - they're all 9 digit businesses. But given the input from @MinThaMie it's probably safer to revert for now and someone to pick up the work of finding out if they still actively use ember. Although Crowdstrike weren't marked as featured, but aren't they fairly prominent ember users? Happy with whatever you all suggest, you have the context, I just see big company names. :) |
So first of all I didn't know that inactive was originally there. From what I can see there is nothing reading this flag on a user so we should remove the whole concept of inactive entirely. As for who to delete, the thing that I said is that if the website is down or pointing at spam (like your original issue mentioned) then the user should 100% just be deleted. That should be the first PR and should not be contentious at all 👍 If there are any other users that have been marked as "inactive" for any other reason then the decision could be considered marginal and we should discuss that in a separate PR or issue 👍
I also didn't know/remember that the featured flag was there 🙈 🫠 I'm ok having a discussion about adding featured to companies but that should be in a separate PR. There should only ever be a single concept in a single PR so that we can have relevant discussions about one idea at a time. As for people like Crowdstrike I wouldn't worry too much about them 😉 they are on the sponsors page and that page doesn't add |
|
With you on all of this, I'll crack on with the deletions and open up a new PR with just that. I'll leave the issue open with the broader conversation and we can pick up the featured companies another time |
|
#1160 replaces this |
3 participants
I've filtered out dead users as per the list in #1158 there was already an inactive flag in
data/userswhich also contains some users that have live products. At some point the work to mark them inactive has already been done, so this might be pruning the list a little too much. I welcome some feedback on this.I've also updated the number of featured users to push some of the larger companies further up the list - again I'd love some feedback on who might be missing, who should not and if there's some reason I'm unaware of for those users to be further down the list.
Something I ran into was an error trying to filter inactive with
store.queryreturning a 400. I don't have enough insight to know why that's the case, but I've left a comment inapp/routes/ember-users.jsany insight would be fantastic. I already asked @NullVoxPopuli and they said someone in the learn team might know more.