Skip to content

Conversation

@coremore35
Copy link
Contributor

@coremore35 coremore35 commented Sep 18, 2025

Screenshot 2025-09-18 at 5 21 59 PM

This pull request introduces a new informational banner to the guides article page when the current version is GJS, and updates related styles for consistency and improved accessibility. The most significant changes are the addition of the GJS info banner component, updates to CSS for the new banner, and several minor style consistency improvements.

Feature addition:

  • Added a conditional info banner to guides-article.hbs that appears when the current version is GJS, informing users that the guide assumes GJS usage and linking to more information. The banner includes an accessible SVG icon and appropriate ARIA labels.

Styling and consistency improvements:

  • Updated .info-banner-wrapper and related CSS classes in addon.css to style the new info banner, including layout, padding, border radius, and link appearance.
  • Modified the shared icon styles so that both the old version warning and info banner icons are consistently sized and aligned.
  • Improved formatting and consistency in CSS selectors and properties, such as spacing, color codes, and selector quoting, to align with project style guidelines. [1] [2] [3] [4] [5]

@netlify
Copy link

netlify bot commented Sep 18, 2025

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/projects/guidemaker-ember-template/deploys/68d6c314320cd7d8e83f5369
😎 Deploy Preview https://deploy-preview-210--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mansona mansona added the enhancement New feature or request label Sep 20, 2025
@mansona mansona changed the base branch from main to native-class September 26, 2025 16:11
@mansona mansona force-pushed the issue_2137_banner branch 2 times, most recently from 2ad1d8b to c7eab10 Compare September 26, 2025 16:38
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution 🎉

@mansona mansona merged commit 773be75 into ember-learn:native-class Sep 26, 2025
11 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants