Remove traces of "Ember.run" in run-loop.md #2104
Open
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure, but Importing Ember global this is deprecated long time ago. Not sure what to do about the example use of`Ember.run. hasOpenRunloop()` as that seems undocumented / untyped / unexported / archaic to me.
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johanrd
commented
Mar 26, 2025
| window.addEventListener('online', () => { | ||
| // 1. autoruns do not change the execution of arbitrary code in a callback. | ||
| // This code is still run when this callback is executed and will not be | ||
| // scheduled on an autorun. | ||
| console.log('Doing things...'); | ||
|
|
||
| Ember.run.schedule('actions', () => { | ||
| schedule('actions', () => { | ||
| // 2. schedule notices that there is no currently available run loop so it | ||
| // creates one. It schedules it to close and flush queues on the next | ||
| // turn of the JS event loop. | ||
| if (! Ember.run.hasOpenRunLoop()) { |
There was a problem hiding this comment.
not sure what to do about this example of Ember.run.hasOpenRunloop() – the method seems undocumented / untyped / without public export / archaic to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure. I know that using the ember runloop is not-recommended in the first place, but when separating out that as a concern: Importing from global Ember is deprecated long time ago.
Not sure what to do about the example use of
Ember.run.hasOpenRunloop()as that seems undocumented / untyped / unexported / archaic to me.