Expose template content as raw_text
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add gts syntax highlighting to Zed, I wasn't able to use `injection.include-children` to inject hbs grammar into the template tag. The pattern of exposing it as raw_text matches Vue and Svelte.
| @@ -47,6 +47,9 @@ noJSX(JavaScript); | |||
| */ | |||
| module.exports = grammar(JavaScript, { | |||
| name: "glimmer_javascript", | |||
|
|
|||
| externals: ($, previous) => previous.concat([$.raw_text]), | |||
There was a problem hiding this comment.
how does externals work? I should have asked this on the other PR -- but I mostly trust the tests to keep anything from regressing
There was a problem hiding this comment.
I misunderstood what it meant! I think it means it gets that variable from an external parser. I based this on Vue and Svelte, and I’m pretty sure they have external parsers. Will create PRs to remove it!
NullVoxPopuli
approved these changes
Mar 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add gts syntax highlighting to Zed, I wasn't able to use
injection.include-childrento inject hbs grammar into the template tag. The pattern of exposing it as raw_text matches Vue and Svelte.