Native support for else and else if in block statements #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogstad
force-pushed
the
push-nksopsusrmto
branch
from
3a42914 to
4c6da7b
Compare
As there isn't a native concept of if statements in the grammar, it makes it especially hard to query `else if` statements, as they've previously just been exposed as a helper. It makes it cumbersome to query `else` blocks and not possible—I think at least—to query and capture `else if` as the same capture. `else` is supported for all block_statements in Ember, but `else if` isn't, but it wouldn't be valid syntax that we want to capture any other way, so I haven't tried to be cleaver about it.
mogstad
force-pushed
the
push-nksopsusrmto
branch
from
4c6da7b to
47f68db
Compare
mogstad
force-pushed
the
push-nksopsusrmto
branch
from
47f68db to
8e0ab76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there isn't a native concept of if statements in the grammar, it makes it especially hard to query
else ifstatements, as they've previously just been exposed as a helper. It makes it cumbersome to queryelseblocks and not possible—I think at least—to query and captureelse ifas the same capture.elseis supported for all block_statements in Ember, butelse ifisn't, but it wouldn't be valid syntax that we want to capture any other way, so I haven't tried to be cleaver about it.I’m unsure if this is the way to solve, but I don’t think it’s unreasonable to have “native” support for it.