Improvement: Setting Up The Project #9543
Open
+60
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
runspired
reviewed
Oct 5, 2024
| if (!CERT_PATH) { | ||
| CERT_PATH = path.join(homedir(), 'holodeck-localhost.pem'); | ||
| process.env.HOLODECK_SSL_CERT_PATH = CERT_PATH; | ||
| execSync(`echo '\nexport HOLODECK_SSL_CERT_PATH="${CERT_PATH}"' >> ${configFilePath}`); |
There was a problem hiding this comment.
IIRC the setup here exists for CI environments.
We should probably gate it with process.env.CI instead of removing it (this is the reason for the failing test scenarios in this PR), though there may be some other nuance that allows us to still remove this but make CI work.
I think the issue is that we don't re-source the ENV after running ensure-cert (see
data/.github/actions/setup/action.yml
Line 75 in 536192b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the
setting-up-the-project.mdfile, based on our findings during the setup of the project on my local environment.pnpxinstead ofnpx. Since the project relies on pnpm, recommend running scripts with pnpm commands
. The only script affected is the holodeck ensure-cert
. Install
mkcertandnss(as needed). Run the ensure-cert script to create the certificates
index.jsfile. Rely on running the ensure-cert script instead