Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 🔸 to tracked dependencies that caused the last invalidation #2546

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

patricklx
Copy link
Collaborator

we also do our own revision/value tracking so we can show the changed deps between the updates

@RobbieTheWagner
Copy link
Member

@patricklx can you please explain what this is doing and add some tests for this? We seem to be making some complex changes here.

@patricklx
Copy link
Collaborator Author

@RobbieTheWagner when a tracked property is changed, it will be marked in the display of tracked deps

@patricklx
Copy link
Collaborator Author

e.g. in power-select after search:
image

@RobbieTheWagner
Copy link
Member

@RobbieTheWagner when a tracked property is changed, it will be marked in the display of tracked deps

@patricklx gotcha, what is the use case for needing to know that? Also, should we add some kind of tooltip explaining what it is?

@patricklx
Copy link
Collaborator Author

If there is some unexpected rendering or recomputation of getters, this will be of help and this came up sometimes in the community

@patricklx
Copy link
Collaborator Author

patricklx commented Feb 6, 2024

A tooltip might be useful. But will need more redesign work of the ux and what we send to the inspector. I would prefer to do that in a separate pr

@RobbieTheWagner
Copy link
Member

A tooltip might be useful. But will need more redesign work of the ux and what we send to the inspector. I would prefer to do that in a separate pr

Sure, that is fine. We just need people to know what this thing is. If not a tooltip, maybe we can add some kind of explanation elsewhere in the app. Either way, it can be a followup.

@RobbieTheWagner RobbieTheWagner merged commit ea7c146 into emberjs:main Feb 6, 2024
15 checks passed
@patricklx patricklx deleted the show-changed-deps branch February 7, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants