Remove application-template-wrapper feature
#1528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobisjan
commented
Jan 27, 2025
| } else { | ||
| context.element = document.querySelector('#ember-testing'); | ||
| } | ||
| context.element = document.querySelector('#ember-testing'); |
There was a problem hiding this comment.
Should be the getRootElement() used instead?
bobisjan
force-pushed
the
application-template-wrapper
branch
2 times, most recently
from
3197f6f to
eac9cf6
Compare
This is a follow-up to emberjs/ember.js#20683
bobisjan
force-pushed
the
application-template-wrapper
branch
from
eac9cf6 to
42edb00
Compare
bobisjan
changed the title
application-temoplate-wrapper featureapplication-template-wrapper feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to emberjs/ember.js#20683