Add failing test for current-when #14787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you migrate this to a QUnit todo? |
|
Sadly, I don't think we can use todo's just yet (testem doesn't support them). |
|
Ah darn :/ Apologies for the suggestion. |
|
☔ The latest upstream changes (presumably #15319) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixed :) testem/testem#1400 |
|
Is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test for a scenario where using
current-whenis not working as expected.I've set up a simple Twiddle, showing that it works as expected without route params, but if route params are introduced, it does not work.
Original issue #14615
Example twiddle