[BUGFIX release] Query params refreshModel #15832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: emberjs#15801 Reproduces the case of a refresh due to a queryParam transition in a child route. *Still requires actual fix.*
|
Is this still relevant? |
|
Sorry for the late response. Not to me, I've left the employment of the organisation for which this was relevant at the time. @rmachielse would likely be able to provide a better answer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces the #15801 in a test case. The problem actually lies in the query param change detection and I'm more than willing to include that. This does demonstrate the most user facing part of this issue.
Any pointers on the best approach to fix this are more than welcome.
While writing this I also noticed that transitioning from the parent route to the child route through the router service, actually triggered a transition abort. I'm convinced this is caused by the same underlying issue, but would be more than willing to include another failing test case to demonstrate that.