Add failing test for query param scoping #17451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
query-param-scoping
branch
2 times, most recently
from
88dd2ad to
b90b4b7
Compare
|
Is this a regression as of 3.6? |
|
@chadhietala I believe it's been present since at least 3.4.6 as we discovered it in our app which is stuck on 3.4 for unrelated reasons. |
wagenet
force-pushed
the
query-param-scoping
branch
2 times, most recently
from
4b426f7 to
2ed3a42
Compare
|
@wagenet is this still relevant? |
wagenet
force-pushed
the
query-param-scoping
branch
from
2ed3a42 to
5b39a38
Compare
|
@locks I just rebased. Looks like CI still fails. |
|
Is this still relevant? |
wagenet
force-pushed
the
query-param-scoping
branch
from
5b39a38 to
06da75b
Compare
|
Rebased again just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that for query param scoping, it is assumed that the only thing that matters are the URL params on the final route. However, it is entirely possible (as shown in the test) that this might not be sufficient to determine uniqueness. It's not clear to me how best to fix this since in some cases this assumption might be correct (e.g. the params are just the ids of Ember Data records) but in others it may not be (e.g. the final route's params aren't sufficient to determine the model).
It should also be noted that the guides say that the query params are tied to the model. This is definitely not correct as we see here. They are tied to the url params of the last route.