Add a failing test for query params cache with resetNamespace #17452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
query-param-cache-reset-namespace
branch
2 times, most recently
from
fb33712 to
9f45268
Compare
|
@wagenet is this still relevant? |
wagenet
force-pushed
the
query-param-cache-reset-namespace
branch
from
9f45268 to
043f85c
Compare
|
@locks I just rebased. Looks like CI still fails. |
|
Is this still relevant? |
wagenet
force-pushed
the
query-param-cache-reset-namespace
branch
from
043f85c to
da5ba58
Compare
|
I just rebased, lets see if it still fails!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic issue here is that the cache key calculator uses the current route name to determine the prefix for the key which enables a correct value lookup. However, if you use
resetNamespacethe prefix won't match and it calculates the prefix incorrectly. In this example, it will try get the value fromparent.child.child_id(IIRC) and instead of that getting the value ofchild_idfrom theparent.childroute, it will try to get the value ofchild.child_idfrom theparentroute.