Skip to content

get route out of hello world#21457

Merged
NullVoxPopuli merged 1 commit into
mainfrom
nvp/get-Route-out-of-hello-world
Jun 10, 2026
Merged

get route out of hello world#21457
NullVoxPopuli merged 1 commit into
mainfrom
nvp/get-Route-out-of-hello-world

Conversation

@NullVoxPopuli

@NullVoxPopuli NullVoxPopuli commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

importing from @ember/routing/-internals is a bad time

this simple change removes Route from the hello-world demo


NOTE: sideEffects: false also achieves the same goal: #21456

but we should ship this PR anyway

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/get-Route-out-of-hello-world branch from 709f9a2 to c2ec51f Compare June 10, 2026 02:36
@NullVoxPopuli NullVoxPopuli requested review from ef4 and kategengler June 10, 2026 02:37
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   -0.01%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/index-{hash}.js 78.5 kB / 19.1 kB -0.17%↓78.4 kB / -0.2%↓19 kB
Total (Includes all files) 2.1 MB / 491.6 kB -0.01%↓2.1 MB / -0.01%↓491.5 kB

dist/prod   -0.01%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/index-{hash}.js 66.5 kB / 16.3 kB -0.21%↓66.4 kB / 0.01%↑16.3 kB
Total (Includes all files) 1.9 MB / 449.7 kB -0.01%↓1.9 MB / -0%↓449.7 kB

smoke-tests/v2-app-hello-world-template/dist   -25.7%↓

File Before (Size / Brotli) After (Size / Brotli)
./assets/main-{hash}.js 234.9 kB / 64.3 kB -25.7%↓174.5 kB / -25%↓48.3 kB
Total (Includes all files) 235.2 kB / 64.5 kB -25.7%↓174.8 kB / -24.9%↓48.4 kB

🤖 This report was automatically generated by wyvox/pkg-size

@mansona mansona left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@NullVoxPopuli NullVoxPopuli merged commit 8a9f078 into main Jun 10, 2026
48 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/get-Route-out-of-hello-world branch June 10, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants