Support embrace hosted attachments#1816
Merged
fractalwrench merged 5 commits intofile-attachment-apifrom Jan 17, 2025
Merged
Conversation
31288fd to
80c6e2e
Compare
430ba91 to
7bd115c
Compare
Base automatically changed from
hosted-attachment-parts
to
file-attachment-api
January 15, 2025 07:10
2e48420 to
f8d67b3
Compare
f8d67b3 to
8422e7e
Compare
8422e7e to
d4626f2
Compare
d4626f2 to
76f1340
Compare
priettt
approved these changes
Jan 16, 2025
Add integration tests for file attachments
Remove size parameter from user hosted log messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Adds support for log attachments that are hosted on Embrace's servers.
Testing
Added basic integration tests. Further tests will follow in a future PR.