Skip to content

Support embrace hosted attachments#1816

Merged
fractalwrench merged 5 commits intofile-attachment-apifrom
embrace-hosted-attachments
Jan 17, 2025
Merged

Support embrace hosted attachments#1816
fractalwrench merged 5 commits intofile-attachment-apifrom
embrace-hosted-attachments

Conversation

@fractalwrench
Copy link
Member

@fractalwrench fractalwrench commented Jan 14, 2025

Goal

Adds support for log attachments that are hosted on Embrace's servers.

Testing

Added basic integration tests. Further tests will follow in a future PR.

@fractalwrench fractalwrench force-pushed the embrace-hosted-attachments branch from 31288fd to 80c6e2e Compare January 14, 2025 12:57
@fractalwrench fractalwrench changed the base branch from file-attachment-api to hosted-attachment-parts January 14, 2025 16:17
@fractalwrench fractalwrench force-pushed the embrace-hosted-attachments branch 3 times, most recently from 430ba91 to 7bd115c Compare January 14, 2025 17:42
Base automatically changed from hosted-attachment-parts to file-attachment-api January 15, 2025 07:10
@fractalwrench fractalwrench force-pushed the embrace-hosted-attachments branch 2 times, most recently from 2e48420 to f8d67b3 Compare January 15, 2025 13:51
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 89.88764% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (2c782cc) to head (244ace1).
Report is 8 commits behind head on file-attachment-api.

Files with missing lines Patch % Lines
...nal/resurrection/PayloadResurrectionServiceImpl.kt 0.00% 0 Missing and 2 partials ⚠️
...elivery/execution/OkHttpRequestExecutionService.kt 95.00% 0 Missing and 2 partials ⚠️
...nal/delivery/storage/CachedLogEnvelopeStoreImpl.kt 0.00% 0 Missing and 2 partials ⚠️
...roid/embracesdk/internal/logs/EmbraceLogService.kt 75.00% 0 Missing and 1 partial ⚠️
...embracesdk/internal/logs/attachments/Attachment.kt 87.50% 1 Missing ⚠️
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           file-attachment-api    #1816      +/-   ##
=======================================================
- Coverage                85.47%   85.46%   -0.02%     
=======================================================
  Files                      473      474       +1     
  Lines                    11043    11083      +40     
  Branches                  1653     1665      +12     
=======================================================
+ Hits                      9439     9472      +33     
+ Misses                     870      869       -1     
- Partials                   734      742       +8     
Files with missing lines Coverage Δ
...oid/embracesdk/internal/injection/LogModuleImpl.kt 92.10% <100.00%> (+0.21%) ⬆️
...ace/android/embracesdk/internal/logs/LogService.kt 100.00% <100.00%> (ø)
...k/internal/logs/attachments/AttachmentErrorCode.kt 100.00% <ø> (ø)
...sdk/internal/logs/attachments/AttachmentService.kt 100.00% <ø> (ø)
...dk/internal/session/orchestrator/V1PayloadStore.kt 80.00% <ø> (ø)
...dk/internal/session/orchestrator/V2PayloadStore.kt 95.12% <100.00%> (+3.23%) ⬆️
...racesdk/internal/delivery/SupportedEnvelopeType.kt 100.00% <100.00%> (ø)
...esdk/internal/delivery/intake/IntakeServiceImpl.kt 100.00% <100.00%> (ø)
...sdk/internal/delivery/storage/AttachmentStorage.kt 100.00% <100.00%> (ø)
...main/java/io/embrace/android/embracesdk/Embrace.kt 86.95% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@fractalwrench fractalwrench force-pushed the embrace-hosted-attachments branch from f8d67b3 to 8422e7e Compare January 15, 2025 14:44
@fractalwrench fractalwrench changed the title [WIP] support embrace hosted attachments Support embrace hosted attachments Jan 15, 2025
@fractalwrench fractalwrench marked this pull request as ready for review January 15, 2025 17:46
@fractalwrench fractalwrench requested a review from a team as a code owner January 15, 2025 17:46
@fractalwrench fractalwrench force-pushed the embrace-hosted-attachments branch from 8422e7e to d4626f2 Compare January 15, 2025 17:48
@fractalwrench fractalwrench force-pushed the embrace-hosted-attachments branch from d4626f2 to 76f1340 Compare January 15, 2025 17:49
Add integration tests for file attachments
Remove size parameter from user hosted log messages
@fractalwrench fractalwrench merged commit f996835 into file-attachment-api Jan 17, 2025
2 of 3 checks passed
@fractalwrench fractalwrench deleted the embrace-hosted-attachments branch January 17, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants