Tweak log attachment implementation after manual testing#1823
Merged
fractalwrench merged 1 commit intofile-attachment-apifrom Jan 17, 2025
Merged
Tweak log attachment implementation after manual testing#1823fractalwrench merged 1 commit intofile-attachment-apifrom
fractalwrench merged 1 commit intofile-attachment-apifrom
Conversation
priettt
reviewed
Jan 16, 2025
| SESSIONS("spans", "v2"), | ||
| CONFIG("config", "v2"), | ||
| ATTACHMENT("attachment", "v2"), | ||
| ATTACHMENT("attachments", "v2"), |
Contributor
There was a problem hiding this comment.
should we also rename the enum type name? ATTACHMENT -> ATTACHMENTS
priettt
approved these changes
Jan 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## file-attachment-api #1823 +/- ##
=======================================================
- Coverage 85.46% 85.46% -0.01%
=======================================================
Files 474 474
Lines 11083 11094 +11
Branches 1665 1668 +3
=======================================================
+ Hits 9472 9481 +9
- Misses 869 871 +2
Partials 742 742
|
Base automatically changed from
embrace-hosted-attachments
to
file-attachment-api
January 17, 2025 07:05
729b8cd to
f1170dc
Compare
f1170dc to
eb9e17e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This changeset contains a few tweaks to the log attachment implementation that were required after carrying out manual testing: