Support creating custom spans and attributes in the startup trace#1824
Merged
bidetofevil merged 1 commit intomainfrom Jan 17, 2025
Merged
Support creating custom spans and attributes in the startup trace#1824bidetofevil merged 1 commit intomainfrom
bidetofevil merged 1 commit intomainfrom
Conversation
Contributor
Author
bd79a8a to
707e582
Compare
This was referenced Jan 16, 2025
1ffb976 to
dfea178
Compare
707e582 to
cdbca55
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 85.38% 85.49% +0.11%
==========================================
Files 473 473
Lines 11015 11048 +33
Branches 1648 1652 +4
==========================================
+ Hits 9405 9446 +41
+ Misses 877 867 -10
- Partials 733 735 +2
|
Contributor
Author
cdbca55 to
db83123
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Add the ability to add custom child spans and attributes to UI load traces. Also exposed a public method to get the SDK timestamp so the custom spans can use the same clock as the rest of the spans i the traces
Testing
Added unit and integration tests