Add log message attachment example#1828
Merged
fractalwrench merged 1 commit intofile-attachment-apifrom Jan 29, 2025
Merged
Conversation
fractalwrench
force-pushed
the
file-attachment-example
branch
from
9f2e056 to
e0372a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## file-attachment-api #1828 +/- ##
=======================================================
- Coverage 85.38% 85.37% -0.01%
=======================================================
Files 474 474
Lines 11158 11158
Branches 1680 1680
=======================================================
- Hits 9527 9526 -1
+ Misses 882 881 -1
- Partials 749 751 +2 |
fractalwrench
force-pushed
the
file-attachment-example
branch
from
e0372a7 to
123496d
Compare
fractalwrench
force-pushed
the
file-attachment-example
branch
from
123496d to
27060c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Adds a log message attachment sample to the example app. As this relies on a new API it won't compile without a local artefact for now, so I'll avoid merging this until the feature has shipped.