Skip to content

Allow UI Load to be enabled remotely#1836

Merged
bidetofevil merged 1 commit intomainfrom
hho/ui-load-remote-config
Jan 23, 2025
Merged

Allow UI Load to be enabled remotely#1836
bidetofevil merged 1 commit intomainfrom
hho/ui-load-remote-config

Conversation

@bidetofevil
Copy link
Contributor

@bidetofevil bidetofevil commented Jan 22, 2025

Goal

Support remote config feature flag to turn on UI Load, default to disabled

Testing

Added unit and integration tests

@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (f29e9ef) to head (d5d4cd0).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1836      +/-   ##
==========================================
- Coverage   85.33%   85.33%   -0.01%     
==========================================
  Files         473      473              
  Lines       11076    11079       +3     
  Branches     1657     1660       +3     
==========================================
+ Hits         9452     9454       +2     
  Misses        888      888              
- Partials      736      737       +1     
Files with missing lines Coverage Δ
...nal/config/behavior/AutoDataCaptureBehaviorImpl.kt 91.66% <100.00%> (+0.36%) ⬆️
.../embracesdk/internal/config/remote/RemoteConfig.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review January 22, 2025 23:59
@bidetofevil bidetofevil requested a review from a team as a code owner January 22, 2025 23:59
Copy link
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

bidetofevil commented Jan 23, 2025

Merge activity

  • Jan 23, 11:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 11:37 AM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 06236d5 into main Jan 23, 2025
8 checks passed
@bidetofevil bidetofevil deleted the hho/ui-load-remote-config branch January 23, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants