Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
fractalwrench
force-pushed
the
refactor-build-plugin
branch
from
74fa9f6 to
81e36ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (76.77%) is below the adjusted base coverage (84.86%). You can increase the head coverage or adjust the Removed Code Behavior. Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 85.36% 76.77% -8.59%
==========================================
Files 474 36 -438
Lines 11158 1701 -9457
Branches 1680 257 -1423
==========================================
- Hits 9525 1306 -8219
+ Misses 882 236 -646
+ Partials 751 159 -592 |
fractalwrench
force-pushed
the
refactor-build-plugin
branch
from
81e36ae to
5d500a9
Compare
fractalwrench
force-pushed
the
refactor-build-plugin
branch
from
5d500a9 to
01d3a22
Compare
priettt
reviewed
Feb 11, 2025
| project.tasks.withType(Detekt::class.java).configureEach { | ||
| jvmTarget = "1.8" | ||
| reports { | ||
| html.required.set(true) |
Contributor
There was a problem hiding this comment.
According to this: https://detekt.dev/docs/gettingstarted/gradle#reports
We only really need to set XML to false. The rest of the report options are already set at their defaults.
reports {
xml.required.set(false)
}
Tweak internal plugin setup
Use version catalog
Split up plugin logic
Update script in preparation for gradle plugin
Renames IntegrationTestRule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Replaces the precompiled build scripts with a build plugin. This adds a plugin extension which allows for greater configurability, which will be necessary for when we're also supporting gradle plugin modules in the project.