Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
fractalwrench
force-pushed
the
workflow-change
branch
16 times, most recently
from
4a81393 to
70675c5
Compare
priettt
approved these changes
Feb 19, 2025
fractalwrench
force-pushed
the
workflow-change
branch
from
70675c5 to
cbe1bd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 483 483
Lines 11248 11248
Branches 1687 1687
=======================================
Hits 9585 9585
- Misses 910 911 +1
+ Partials 753 752 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixes the publishing workflow on CI by ensuring javadoc + source JARs are added to the publication for the gradle plugin. Additionally prevent the integration test plugin from getting uploaded by removing the task from execution in the CI workflow.
Testing
Ran the workflow and confirmed artifacts were uploaded in a closed state & an example app could compile with them: https://github.com/embrace-io/embrace-android-sdk/actions/runs/13369659964