Skip to content

Create child span for time waiting for manual UI load ending#1933

Merged
bidetofevil merged 1 commit intomainfrom
hho/ui-ready-span
Feb 24, 2025
Merged

Create child span for time waiting for manual UI load ending#1933
bidetofevil merged 1 commit intomainfrom
hho/ui-ready-span

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Feb 21, 2025

Goal

Add extra child span modelling the time after activity resumes to when the trace is manually terminated for completeness.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 21, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Feb 21, 2025

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (ac5d621) to head (33cab84).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 62.06% 9 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
- Coverage   85.25%   85.24%   -0.01%     
==========================================
  Files         483      483              
  Lines       11240    11261      +21     
  Branches     1687     1689       +2     
==========================================
+ Hits         9583     9600      +17     
- Misses        902      905       +3     
- Partials      755      756       +1     
Files with missing lines Coverage Δ
...acesdk/internal/capture/activity/LifecycleStage.kt 100.00% <100.00%> (ø)
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 80.89% <62.06%> (-0.87%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/ui-ready-span branch 2 times, most recently from 9d18285 to 2b80ab4 Compare February 24, 2025 17:47
Copy link
Copy Markdown
Contributor Author

bidetofevil commented Feb 24, 2025

Merge activity

  • Feb 24, 12:48 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 24, 1:08 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 24, 1:21 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 24, 1:36 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit a7a0cdd into main Feb 24, 2025
10 checks passed
@bidetofevil bidetofevil deleted the hho/ui-ready-span branch February 24, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants