Skip to content

Stop respecting obsolete project properties#1992

Merged
fractalwrench merged 12 commits intomainfrom
remove-unused-proj-properties
Mar 7, 2025
Merged

Stop respecting obsolete project properties#1992
fractalwrench merged 12 commits intomainfrom
remove-unused-proj-properties

Conversation

@fractalwrench
Copy link
Member

Goal

Stop respecting the obsolete project properties embrace.logLevel and embrace.instrumentationScope. Log level can be controlled via Gradle directly so we don't need our own logic to achieve this. Instrumentation scope has not been used in practice so is not required.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 6, 2025 10:32
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FINALLY

@fractalwrench fractalwrench merged commit bfc95ce into main Mar 7, 2025
10 checks passed
@fractalwrench fractalwrench deleted the remove-unused-proj-properties branch March 7, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants