Skip to content

Delete v1 delivery layer#2011

Merged
fractalwrench merged 1 commit intomainfrom
delete-v1-delivery-layer
Mar 11, 2025
Merged

Delete v1 delivery layer#2011
fractalwrench merged 1 commit intomainfrom
delete-v1-delivery-layer

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Deletes the v1 delivery layer.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner March 10, 2025 14:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (fb93051) to head (6542619).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...esdk/internal/injection/PayloadSourceModuleImpl.kt 66.66% 0 Missing and 3 partials ⚠️
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 75.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
- Coverage   85.37%   85.25%   -0.13%     
==========================================
  Files         482      464      -18     
  Lines       11234    10502     -732     
  Branches     1686     1550     -136     
==========================================
- Hits         9591     8953     -638     
+ Misses        902      875      -27     
+ Partials      741      674      -67     
Files with missing lines Coverage Δ
...oid/embracesdk/internal/comms/api/ApiRequestExt.kt 100.00% <ø> (+5.00%) ⬆️
...nal/config/behavior/AutoDataCaptureBehaviorImpl.kt 89.47% <ø> (-2.53%) ⬇️
...mbracesdk/internal/injection/DeliveryModuleImpl.kt 86.31% <100.00%> (+7.55%) ⬆️
...cesdk/internal/injection/DeliveryModuleSupplier.kt 100.00% <ø> (ø)
...k/internal/injection/EssentialServiceModuleImpl.kt 100.00% <ø> (+3.33%) ⬆️
...ternal/injection/EssentialServiceModuleSupplier.kt 100.00% <ø> (ø)
...embracesdk/internal/injection/StorageModuleImpl.kt 100.00% <ø> (ø)
...cesdk/internal/injection/WorkerThreadModuleImpl.kt 96.42% <100.00%> (-0.45%) ⬇️
...rnal/session/message/PayloadMessageCollatorImpl.kt 100.00% <ø> (ø)
.../internal/session/orchestrator/PayloadStoreImpl.kt 95.12% <ø> (ø)
... and 5 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill it with fire

@fractalwrench fractalwrench force-pushed the delete-v1-delivery-layer branch from 0fb5bfe to 6542619 Compare March 11, 2025 13:55
@fractalwrench fractalwrench merged commit c210f21 into main Mar 11, 2025
10 checks passed
@fractalwrench fractalwrench deleted the delete-v1-delivery-layer branch March 11, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants