Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
83109d9 to
97a521a
Compare
| * 1. Compresses each shared object file using Zstd compression | ||
| * 2. Stores the compressed files in compressedSharedObjectFilesDirectory, preserving the architecture directory structure |
There was a problem hiding this comment.
I didn't realise we were doing Zstd compression on SO files. IMO it'd be worth breaking that into a separate task that takes the uncompressed SO files as an input and the compressed files as an output. Sorry for the confusion from our discussion yesterday
|
|
||
| // Serialize the map to JSON and write it to the output file | ||
| val serializableMap = ArchitecturesToHashedSharedObjectFilesMap(outputMap) | ||
| architecturesToHashedSharedObjectFilesMap.get().asFile.outputStream().use { outputStream -> |
There was a problem hiding this comment.
| architecturesToHashedSharedObjectFilesMap.get().asFile.outputStream().use { outputStream -> | |
| architecturesToHashedSharedObjectFilesMap.get().asFile.outputStream().use { outputStream -> |
It'd be worth using a buffered stream here to improve perf
| } | ||
|
|
||
| private fun getUnitySharedObjectFiles(project: Project, data: AndroidCompactedVariantData): File { | ||
| // TODO: Verify if errors should be thrown if the directories or SO files are not found. Improve error messaging. |
There was a problem hiding this comment.
Are these todo comments new or were they present in the previous code that's been adapted into this source file?
There was a problem hiding this comment.
these are new, I'm adding them so I can then think about any uncommon codepaths
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2023 +/- ##
==========================================
+ Coverage 85.25% 85.40% +0.14%
==========================================
Files 464 466 +2
Lines 10518 10523 +5
Branches 1556 1558 +2
==========================================
+ Hits 8967 8987 +20
+ Misses 875 858 -17
- Partials 676 678 +2 🚀 New features to boost your workflow:
|
Goal
This is one of the 4 tasks NdkUploadTask will get separated into.
This task receives a directory with architectures as its input, and outputs a map of each architecture to a list with every shared object file path of that architecture.
For instance, if the input directory is this:
The result will be this map:
I also moved the logic to find the architecture directories to the task registration, so it's passed as a provider to the task.
Testing
Added an integration test for the task, still need to test the registration.