Set correct total limits on OTel layer#2056
Merged
bidetofevil merged 1 commit intomainfrom Mar 24, 2025
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 85.23% 85.26% +0.03%
==========================================
Files 468 468
Lines 10570 10577 +7
Branches 1565 1563 -2
==========================================
+ Hits 9009 9019 +10
- Misses 878 879 +1
+ Partials 683 679 -4
🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Apply the total limits of attributes, event, and links correctly on the OTel layer, separating the ones added by users and others added by the SDK. The notion of system links was also added in this PR.
We were using the system one for the total when applying it at the OTel layer, which theoretically should be way more than needed, and should easily absorb the user ones without issue. Fixing this makes the OTel layer agree with the SDK layer, so if you can add an attribute through the SDK, it will be exported for sure.
Some method names on the
CurrentSessionSpaninterface was also renamed to clarify what it's doing