Skip to content

Set correct total limits on OTel layer#2056

Merged
bidetofevil merged 1 commit intomainfrom
hho/limits-fix
Mar 24, 2025
Merged

Set correct total limits on OTel layer#2056
bidetofevil merged 1 commit intomainfrom
hho/limits-fix

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 21, 2025

Goal

Apply the total limits of attributes, event, and links correctly on the OTel layer, separating the ones added by users and others added by the SDK. The notion of system links was also added in this PR.

We were using the system one for the total when applying it at the OTel layer, which theoretically should be way more than needed, and should easily absorb the user ones without issue. Fixing this makes the OTel layer agree with the SDK layer, so if you can add an attribute through the SDK, it will be exported for sure.

Some method names on the CurrentSessionSpan interface was also renamed to clarify what it's doing

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil marked this pull request as ready for review March 21, 2025 17:33
@bidetofevil bidetofevil requested a review from a team as a code owner March 21, 2025 17:33
@bidetofevil bidetofevil requested review from fnewberg and fractalwrench and removed request for fnewberg March 21, 2025 17:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (9825312) to head (5ca3a4b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 76.19% 3 Missing and 2 partials ⚠️
.../android/embracesdk/internal/payload/SpanMapper.kt 0.00% 1 Missing ⚠️
...mbracesdk/internal/spans/PersistableEmbraceSpan.kt 0.00% 1 Missing ⚠️
...dk/internal/capture/crumbs/BreadcrumbDataSource.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
+ Coverage   85.23%   85.26%   +0.03%     
==========================================
  Files         468      468              
  Lines       10570    10577       +7     
  Branches     1565     1563       -2     
==========================================
+ Hits         9009     9019      +10     
- Misses        878      879       +1     
+ Partials      683      679       -4     
Files with missing lines Coverage Δ
...ternal/capture/session/EmbraceSessionProperties.kt 96.49% <100.00%> (ø)
...racesdk/internal/opentelemetry/OpenTelemetrySdk.kt 100.00% <100.00%> (ø)
...al/session/orchestrator/SessionOrchestratorImpl.kt 91.81% <100.00%> (ø)
...ssion/orchestrator/SessionSpanAttrPopulatorImpl.kt 93.93% <100.00%> (ø)
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 88.75% <ø> (ø)
...oid/embracesdk/internal/spans/EmbraceExtensions.kt 77.77% <100.00%> (+2.02%) ⬆️
...droid/embracesdk/internal/spans/EmbraceLinkData.kt 100.00% <100.00%> (ø)
...ernal/capture/crumbs/PushNotificationDataSource.kt 88.88% <100.00%> (ø)
...mbracesdk/internal/capture/crumbs/TapDataSource.kt 86.66% <100.00%> (ø)
...dk/internal/capture/crumbs/WebViewUrlDataSource.kt 68.75% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Mar 24, 2025

Merge activity

  • Mar 24, 10:21 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 24, 10:21 AM EDT: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 66c8cf4 into main Mar 24, 2025
11 checks passed
@bidetofevil bidetofevil deleted the hho/limits-fix branch March 24, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants