Skip to content

Allow custom resource attributes to be set on otel SDK instance#2090

Merged
bidetofevil merged 1 commit intomainfrom
hho/custom-resoure-attr
Apr 11, 2025
Merged

Allow custom resource attributes to be set on otel SDK instance#2090
bidetofevil merged 1 commit intomainfrom
hho/custom-resoure-attr

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Apr 11, 2025

Goal

Public API for setting custom resource attributes for exported OTel signals sent to Collectors.

Testing

Unit and integration tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

import org.junit.runner.RunWith

@RunWith(AndroidJUnit4::class)
internal class OTelExportTest {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the Log and Span exporter tests because it makes sense to test them all as one feature

@bidetofevil bidetofevil marked this pull request as ready for review April 11, 2025 00:05
@bidetofevil bidetofevil requested review from a team, fnewberg and fractalwrench as code owners April 11, 2025 00:05
Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/custom-resoure-attr branch from 1840225 to 1719a38 Compare April 11, 2025 15:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (003779b) to head (1719a38).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2090   +/-   ##
=======================================
  Coverage   85.36%   85.37%           
=======================================
  Files         468      469    +1     
  Lines       10577    10582    +5     
  Branches     1563     1564    +1     
=======================================
+ Hits         9029     9034    +5     
- Misses        868      869    +1     
+ Partials      680      679    -1     
Files with missing lines Coverage Δ
...embrace/android/embracesdk/internal/api/OTelApi.kt 100.00% <100.00%> (ø)
...ternal/opentelemetry/OpenTelemetryConfiguration.kt 100.00% <100.00%> (ø)
...racesdk/internal/opentelemetry/OpenTelemetrySdk.kt 100.00% <100.00%> (ø)
...main/java/io/embrace/android/embracesdk/Embrace.kt 87.50% <100.00%> (-0.85%) ⬇️
...mbracesdk/internal/api/delegate/OTelApiDelegate.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Apr 11, 2025

Merge activity

  • Apr 11, 11:55 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 11, 11:55 AM EDT: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit a55bc28 into main Apr 11, 2025
11 checks passed
@bidetofevil bidetofevil deleted the hho/custom-resoure-attr branch April 11, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants