Allow custom resource attributes to be set on otel SDK instance#2090
Merged
bidetofevil merged 1 commit intomainfrom Apr 11, 2025
Merged
Allow custom resource attributes to be set on otel SDK instance#2090bidetofevil merged 1 commit intomainfrom
bidetofevil merged 1 commit intomainfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
bidetofevil
commented
Apr 11, 2025
| import org.junit.runner.RunWith | ||
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| internal class OTelExportTest { |
Contributor
Author
There was a problem hiding this comment.
I merged the Log and Span exporter tests because it makes sense to test them all as one feature
1840225 to
1719a38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2090 +/- ##
=======================================
Coverage 85.36% 85.37%
=======================================
Files 468 469 +1
Lines 10577 10582 +5
Branches 1563 1564 +1
=======================================
+ Hits 9029 9034 +5
- Misses 868 869 +1
+ Partials 680 679 -1
🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Public API for setting custom resource attributes for exported OTel signals sent to Collectors.
Testing
Unit and integration tests